Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patient Consultation: Route to Facility 🏥, Admission Date & Time 🕚 #6458

Merged
merged 12 commits into from
Nov 22, 2023
Merged

Patient Consultation: Route to Facility 🏥, Admission Date & Time 🕚 #6458

merged 12 commits into from
Nov 22, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 17, 2023 •
edited
Loading

WHAT

🤖 Generated by Copilot at 8be51d1

This pull request updates the UI and logic for the consultation form and details page, as well as the treatment summary and patient info card components. It adds new fields and options for the route to facility, ICU admission date, referral and transfer history, and treating physician. It also improves the date and time formatting and removes unused constants.

Required Backend PRs

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 8be51d1

  • Replace the consultation status field with the route to facility field in the consultation form and details page (link, link, link, link, link)
  • Replace the verified by field with the treating physician field in the consultation form and details page (link, link, link)
  • Add new fields and options for referral and transfer in the consultation form and details page (link, link)
  • Show the admission date with time instead of just date in the treatment summary page and the patient info card (link, link, link)
  • Remove the unused CONSULTATION_STATUS constant from the constants.tsx file (link)

@rithviknishad rithviknishad requested a review from a team October 17, 2023 05:40
@rithviknishad rithviknishad requested a review from a team as a code owner October 17, 2023 05:40
@rithviknishad rithviknishad requested a review from bodhish October 17, 2023 05:40
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 99f2b14
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655d7157985d420008cd921c
😎 Deploy Preview https://deploy-preview-6458--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 3:12am

@rithviknishad rithviknishad changed the title Patient Consultation: Route to Facility 🏥, Admission Date & Time Patient Consultation: Route to Facility 🏥, Admission Date & Time 🕚 Oct 17, 2023
@rithviknishad rithviknishad mentioned this pull request Oct 17, 2023
Merged
4 tasks
@cypress
Copy link

cypress bot commented Oct 17, 2023 •
edited
Loading

2 failed tests on run #1597 ↗︎

2 83 0 0 Flakiness 0

Details:

Patient Consultation: Route to Facility 🏥, Admission Date & Time 🕚
Project: CARE Commit: 99f2b140b2
Status: Failed Duration: 03:31 💡
Started: Nov 22, 2023 3:15 AM Ended: Nov 22, 2023 3:18 AM
Failed  cypress/e2e/patient_spec/patient_crud.cy.ts • 2 failed tests

View Output

Test Artifacts
Patient Creation with consultation > Create a New consultation to existing patient Test Replay Screenshots
Patient Creation with consultation > Edit created consultation to existing patient Test Replay Screenshots

Review all test suite changes for PR #6458 ↗︎

@nihal467
Copy link
Member

nihal467 commented Oct 17, 2023 •
edited
Loading

@rithviknishad
image

  • keep the Name of the referring Facility and the Name of the referring Doctor in two rows
image
  • when the admission date to facility is 16/08/2023, the dates for the ICU limited to 16/08/2023, even though today's date is 18/10/2023, is it a intentional behaviour

@rithviknishad
Copy link
Member Author

@nihal467 nope, that's not an intentional behaviour as per discussions made. My bad, I had accidentally forgot to remove the range constraints.

@rithviknishad
Copy link
Member Author

@nihal467 ready for testing

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 20, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 20, 2023
@nihal467
Copy link
Member

@rithviknishad functionality looks good to me, but the cypress and backend test are failing, update it

@rithviknishad
Copy link
Member Author

@nihal467 backend tests fixed, cypress will require the backend to be merged to pass.

@rithviknishad
Copy link
Member Author

rithviknishad commented Oct 25, 2023 •
edited
Loading

cypress passing locally with backend

image

@rithviknishad rithviknishad mentioned this pull request Nov 6, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 9, 2023
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Nov 14, 2023
@rithviknishad rithviknishad mentioned this pull request Nov 21, 2023
Closed
@nihal467 nihal467 linked an issue Nov 21, 2023 that may be closed by this pull request
Death datetime before admission date shouldn't be restricted #6678
Closed
@khavinshankar khavinshankar merged commit c1c4e56 into develop Nov 22, 2023
54 of 59 checks passed
@khavinshankar khavinshankar deleted the consultation/route-to-facility branch November 22, 2023 06:40
@github-actions GitHub Actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
Backend tested
Projects
None yet
Milestone
No milestone
3 participants
@rithviknishad @nihal467 @khavinshankar